Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve FTP coverage #1207

Merged
merged 1 commit into from
Sep 23, 2023
Merged

Improve FTP coverage #1207

merged 1 commit into from
Sep 23, 2023

Conversation

egecetin
Copy link
Collaborator

@egecetin egecetin commented Sep 22, 2023

Some information had dots, some did not. All dots have been removed to match all strings.

@codecov
Copy link

codecov bot commented Sep 22, 2023

Codecov Report

Merging #1207 (76db692) into dev (46d1f05) will increase coverage by 0.62%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##              dev    #1207      +/-   ##
==========================================
+ Coverage   81.70%   82.32%   +0.62%     
==========================================
  Files         157      157              
  Lines       20180    20180              
  Branches     7624     7624              
==========================================
+ Hits        16488    16614     +126     
+ Misses       3071     2942     -129     
- Partials      621      624       +3     
Flag Coverage Δ
alpine317 69.51% <100.00%> (+0.97%) ⬆️
centos7 72.88% <100.00%> (+0.96%) ⬆️
fedora37 69.34% <100.00%> (+0.98%) ⬆️
macos-11 60.87% <100.00%> (+0.76%) ⬆️
macos-12 60.92% <100.00%> (+0.76%) ⬆️
macos-ventura 60.89% <100.00%> (+0.77%) ⬆️
mingw32 69.68% <100.00%> (+0.92%) ⬆️
mingw64 69.68% <100.00%> (+0.90%) ⬆️
npcap 82.80% <100.00%> (+0.69%) ⬆️
ubuntu1804 73.09% <100.00%> (+0.96%) ⬆️
ubuntu2004 70.19% <100.00%> (+0.98%) ⬆️
ubuntu2204 69.11% <100.00%> (+0.96%) ⬆️
ubuntu2204-icpx 59.23% <0.00%> (+0.01%) ⬆️
unittest 82.32% <100.00%> (+0.62%) ⬆️
windows-2019 82.83% <100.00%> (+0.71%) ⬆️
windows-2022 82.85% <100.00%> (+0.72%) ⬆️
winpcap 82.81% <100.00%> (+0.73%) ⬆️
zstd 72.71% <100.00%> (+0.76%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
Packet++/src/FtpLayer.cpp 99.10% <100.00%> (+56.95%) ⬆️

... and 4 files with indirect coverage changes

@egecetin egecetin marked this pull request as ready for review September 22, 2023 11:20
@egecetin egecetin merged commit 2382c3d into seladb:dev Sep 23, 2023
35 checks passed
@egecetin egecetin deleted the ftp-inc-cov branch September 23, 2023 07:15
fxlb pushed a commit to fxlb/PcapPlusPlus that referenced this pull request Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants