Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When uploading packages create a new release as draft #1202

Merged
merged 1 commit into from
Sep 19, 2023

Conversation

seladb
Copy link
Owner

@seladb seladb commented Sep 18, 2023

When creating and uploading packages, create the new release to be in draft so we can later add release notes etc.

@codecov
Copy link

codecov bot commented Sep 18, 2023

Codecov Report

Merging #1202 (166e450) into dev (897aa35) will not change coverage.
Report is 1 commits behind head on dev.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev    #1202   +/-   ##
=======================================
  Coverage   82.11%   82.11%           
=======================================
  Files         157      157           
  Lines       20147    20147           
  Branches     7517     7517           
=======================================
  Hits        16543    16543           
+ Misses       3072     3068    -4     
- Partials      532      536    +4     
Flag Coverage Δ
alpine317 68.56% <ø> (ø)
centos7 71.92% <ø> (ø)
fedora37 68.39% <ø> (ø)
macos-11 60.67% <ø> (+0.06%) ⬆️
macos-12 60.73% <ø> (ø)
macos-ventura 60.67% <ø> (-0.01%) ⬇️
mingw32 68.80% <ø> (ø)
mingw64 68.82% <ø> (ø)
npcap 82.12% <ø> (ø)
ubuntu1804 72.14% <ø> (ø)
ubuntu2004 69.24% <ø> (+0.03%) ⬆️
ubuntu2204 68.13% <ø> (+<0.01%) ⬆️
ubuntu2204-icpx 59.50% <ø> (ø)
unittest 82.11% <ø> (ø)
windows-2019 82.13% <ø> (ø)
windows-2022 82.14% <ø> (ø)
winpcap 82.11% <ø> (+0.01%) ⬆️
zstd 72.48% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 20 files with indirect coverage changes

@clementperon clementperon merged commit 21656bf into dev Sep 19, 2023
35 checks passed
@clementperon clementperon deleted the release-draft branch September 19, 2023 09:12
fxlb pushed a commit to fxlb/PcapPlusPlus that referenced this pull request Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants