Command Tag Implementation #419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Things to add before merge:
|
sekwah41
requested changes
May 21, 2024
core/src/main/java/com/sekwah/advancedportals/core/tags/activation/CommandTag.java
Outdated
Show resolved
Hide resolved
|
This needs to be reviewed ASAP as Velocity/Bungee and server tags are reliant on this. |
|
pre-commit.ci run |
sekwah41
force-pushed
the
CommandTag
branch
3 times, most recently
from
b26c627
to
085a028
Compare
The console executes the player at a certain command source and it is more accurate for it to be the server in this case. Also useful for velocity/bungee iterations
for more information, see https://pre-commit.ci
…suggestion action
|
If everything here is all good in RE: to command tags, probably best to merge and then add further commits via PRs |
|
Merging into an off-branch and will finish. Currently it behaves different to the old tags though is good solid base for 95% of it all :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.