Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Best practices for backup: rsync #146

Merged
merged 25 commits into from
Feb 2, 2021
Merged

Best practices for backup: rsync #146

merged 25 commits into from
Feb 2, 2021

Conversation

core-man
Copy link
Member

@core-man core-man commented Feb 1, 2021

Related to #43.

@core-man core-man changed the title Best practices for backup: rsync WIP: Best practices for backup: rsync Feb 1, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Feb 1, 2021

This comment was written by the Continuous Documentation bot!

@core-man core-man changed the title WIP: Best practices for backup: rsync Best practices for backup: rsync Feb 1, 2021
@core-man core-man requested a review from seisman February 1, 2021 15:32
Copy link
Member

@seisman seisman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made some suggestions to the backup script, but I didn't run it.

Are you running the script in your daily life?

source/best-practices/backup.rst Outdated Show resolved Hide resolved
source/best-practices/backup.rst Outdated Show resolved Hide resolved
source/best-practices/backup.rst Outdated Show resolved Hide resolved
source/best-practices/backup.rst Outdated Show resolved Hide resolved
source/best-practices/backup.rst Outdated Show resolved Hide resolved
source/best-practices/backup.sh Outdated Show resolved Hide resolved
source/best-practices/backup.sh Outdated Show resolved Hide resolved
source/best-practices/backup.sh Outdated Show resolved Hide resolved
source/best-practices/backup.sh Outdated Show resolved Hide resolved
source/best-practices/backup.sh Outdated Show resolved Hide resolved
@core-man
Copy link
Member Author

core-man commented Feb 2, 2021

I made some suggestions to the backup script, but I didn't run it.

Are you running the script in your daily life?

usually every month. I convert it from perl.

Copy link
Member

@seisman seisman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run the backup script again to make sure it works after applying my suggestions. After that this PR is good to merge.

@seisman seisman self-requested a review February 2, 2021 05:52
@seisman
Copy link
Member

seisman commented Feb 2, 2021

Have you read section 6 in this post (https://www.ruanyifeng.com/blog/2020/08/rsync.html)?

@core-man
Copy link
Member Author

core-man commented Feb 2, 2021

Have you read section 6 in this post (https://www.ruanyifeng.com/blog/2020/08/rsync.html)?

Yes, I have read it. But I think we need a mirror, right? Do we want to do incremental backups?

@seisman
Copy link
Member

seisman commented Feb 2, 2021

Have you read section 6 in this post (https://www.ruanyifeng.com/blog/2020/08/rsync.html)?

Yes, I have read it. But I think we need a mirror, right? Do we want to do incremental backups?

It's unclear to me what "a mirror" means.

The current script works well, but it's still risky. We will have big trouble if we backup files weekly and realized that we did something wrong two weeks ago.

@core-man
Copy link
Member Author

core-man commented Feb 2, 2021

The current script works well, but it's still risky. We will have big trouble if we backup files weekly and realized that we did something wrong two weeks ago.

That's a problem. Let's fix it later.

@core-man core-man mentioned this pull request Feb 2, 2021
10 tasks
@core-man core-man merged commit 4b3a4a6 into main Feb 2, 2021
@core-man core-man deleted the backup-rsync branch February 2, 2021 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants