Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not skip headers for DDL #10

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Do not skip headers for DDL #10

wants to merge 1 commit into from

Conversation

Bobochka
Copy link

No description provided.

@tejasmanohar
Copy link
Contributor

tejasmanohar commented Jul 20, 2018 •
edited
Loading

I wish there was a better way to do this. Maybe the right solution would've been to not skip headers at all, but it could also be too late for that :\

Anyways, I'm ok with this PR, but it needs a test :)

@tejasmanohar tejasmanohar self-requested a review July 20, 2018 12:35
tejasmanohar
tejasmanohar suggested changes Jul 22, 2018
View reviewed changes
Copy link
Contributor

@tejasmanohar tejasmanohar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests

@tejasmanohar tejasmanohar mentioned this pull request Sep 20, 2018
Closed
@nfssdq nfssdq mentioned this pull request Sep 23, 2018
Merged
@joegrasse joegrasse mentioned this pull request Mar 11, 2019
Open
@riyadhalnur riyadhalnur mentioned this pull request Dec 31, 2019
Open
@muroon muroon mentioned this pull request Nov 13, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tejasmanohar tejasmanohar tejasmanohar requested changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Bobochka @tejasmanohar