fix: ensure test for environ fromMap is deterministic (#230)

segmentio · Sep 24, 2019 · f581b8e · f581b8e
1 parent 40375db
commit f581b8e
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/environ/environ.go b/environ/environ.go
@@ -53,6 +53,7 @@ func (e *Environ) Map() map[string]string {
 	return ret
 }
 
+// fromMap returns an Environ based on m. Order is arbitrary.
 func fromMap(m map[string]string) Environ {
 	e := make([]string, 0, len(m))
 

diff --git a/environ/environ_test.go b/environ/environ_test.go
@@ -1,6 +1,7 @@
 package environ
 
 import (
+	"sort"
 	"testing"
 
 	"github.com/segmentio/chamber/store"
@@ -177,6 +178,8 @@ func TestFromMap(t *testing.T) {
 	for _, tc := range cases {
 		t.Run(tc.name, func(t *testing.T) {
 			e := fromMap(tc.in)
+			// maps order is non-deterministic
+			sort.Strings(e)
 			assert.EqualValues(t, e, tc.out)
 		})
 	}