Skip to content

Commit

Permalink
Update docker login github action module and docker hub PAT secret na…
Browse files Browse the repository at this point in the history
…me (#345)

Docker login job was failing because the module was outdated. We also addressed Docker recommendation to use PAT instead of password.
  • Loading branch information
rikez authored May 10, 2022
1 parent 5000085 commit 5c5eb3f
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ jobs:
- uses: actions/checkout@v2

- name: Login to DockerHub
uses: docker/login-action@v1
uses: docker/login-action@v2
with:
username: ${{ secrets.DOCKERHUB_USER }}
password: ${{ secrets.DOCKERHUB_PASSWD }}
password: ${{ secrets.DOCKERHUB_TOKEN }}
4 changes: 2 additions & 2 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -80,10 +80,10 @@ jobs:
uses: docker/setup-buildx-action@v1

- name: Login to DockerHub
uses: docker/login-action@v1
uses: docker/login-action@v2
with:
username: ${{ secrets.DOCKERHUB_USER }}
password: ${{ secrets.DOCKERHUB_PASSWD }}
password: ${{ secrets.DOCKERHUB_TOKEN }}

- name: Release
run:
Expand Down

0 comments on commit 5c5eb3f

Please sign in to comment.