Added queueName option for custom dataLayer #758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@CarlosMecha please review, or advise what the process is for requesting a review. This change is partly inspired by this issue. |
|
Happy birthday to this PR. It addresses the need in #282 so why hasn't it been reviewed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Google Tag Manager supports custom queue (dataLayer) name but the existing integration does not allow for this. This change adds a
queueNameoption to the GTM integration to support this.Are there breaking changes in this PR?
No. This change adds an optional option which defaults to
dataLayerso that it will continue to function as prior to the change.Testing
Testing completed successfully. Unit tests were updated to test the new queueName option.
Any background context you want to provide?
This change is needed to aid migration from on-site GTM to Segment destination for large or complex websites which cannot implement the migration all at once. Without this change, a GTM destination cannot be added to a Segment source without breaking an existing GTM implementation.
Is there parity with the server-side/android/iOS integration components (if applicable)?
No
Does this require a new integration setting? If so, please explain how the new setting works
Yes.
Links to helpful docs and other external resources