add cloning

segmentio · Jul 10, 2024 · 8042381 · 8042381
1 parent 6423853
commit 8042381
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/packages/signals/signals/src/core/client/__tests__/redact.test.ts b/packages/signals/signals/src/core/client/__tests__/redact.test.ts
@@ -100,4 +100,15 @@ describe(redactSignalData, () => {
     })
     expect(redactSignalData(signal)).toEqual(expected)
   })
+
+  it('should not mutate the original signal object', () => {
+    const originalSignal = createInteractionSignal({
+      eventType: 'click',
+      target: { value: 'sensitiveData' },
+    })
+    const originalSignalCopy = JSON.parse(JSON.stringify(originalSignal))
+
+    redactSignalData(originalSignal)
+    expect(originalSignal).toEqual(originalSignalCopy)
+  })
 })
diff --git a/packages/signals/signals/src/core/client/redact.ts b/packages/signals/signals/src/core/client/redact.ts
@@ -1,6 +1,7 @@
 import { Signal } from '../../types'
 
-export const redactSignalData = (signal: Signal): Signal => {
+export const redactSignalData = (signalArg: Signal): Signal => {
+  const signal = structuredClone(signalArg)
   if (signal.type === 'instrumentation' || signal.type === 'userDefined') {
     return signal
   } else if (signal.type === 'interaction') {