-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Braze] Add MultiStatus Response support #2423
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2423 +/- ##
=======================================
Coverage ? 78.04%
=======================================
Files ? 982
Lines ? 17114
Branches ? 3212
=======================================
Hits ? 13356
Misses ? 2688
Partials ? 1070 ☔ View full report in Codecov by Sentry. |
96ae34c
to
a1d92b3
Compare
69d3141
to
c394f2e
Compare
I see that you have added the multistatus to the V2 actions. Do you plan to also add it to the original (V1) actions? |
Hey Sayan, this seems like a sizable change and while you don't change the event-delivery side of things, reporting does change. Can you provide evidence of testing in Staging to make sure we all understand how the destination will change? An example can be found here. +1 to Maryam's question. |
Hi @marinhero and @maryamsharif the change has been made to both the V1 and V2 Actions. Since the action definitions call methods defined in |
c394f2e
to
81626f2
Compare
This PR adds MultiStatus support to Actions Braze (Cloud Mode).
Testing
Tested with Unit Tests, Local env and Stage env.
Test doc available here.