Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Braze] Add MultiStatus Response support #2423

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

sayan-das-in
Copy link
Contributor

@sayan-das-in sayan-das-in commented Sep 19, 2024

This PR adds MultiStatus support to Actions Braze (Cloud Mode).

Testing

Tested with Unit Tests, Local env and Stage env.
Test doc available here.

  • Added unit tests for new functionality
  • Tested end-to-end using the local server
  • [Segmenters] Tested in the staging environment

Copy link

codecov bot commented Sep 19, 2024

Codecov Report

Attention: Patch coverage is 90.90909% with 9 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@e4f699d). Learn more about missing BASE report.
Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
...estination-actions/src/destinations/braze/utils.ts 90.32% 2 Missing and 7 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2423   +/-   ##
=======================================
  Coverage        ?   78.04%           
=======================================
  Files           ?      982           
  Lines           ?    17114           
  Branches        ?     3212           
=======================================
  Hits            ?    13356           
  Misses          ?     2688           
  Partials        ?     1070           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maryamsharif
Copy link
Contributor

I see that you have added the multistatus to the V2 actions. Do you plan to also add it to the original (V1) actions?

@marinhero
Copy link
Contributor

marinhero commented Sep 30, 2024

Hey Sayan, this seems like a sizable change and while you don't change the event-delivery side of things, reporting does change. Can you provide evidence of testing in Staging to make sure we all understand how the destination will change? An example can be found here.

+1 to Maryam's question.

@sayan-das-in
Copy link
Contributor Author

Hi @marinhero and @maryamsharif the change has been made to both the V1 and V2 Actions. Since the action definitions call methods defined in utils.ts, the change is made there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants