Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[google sheets] mark batch_size and batch_bytes are non-required field #2405

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

varadarajan-tw
Copy link
Contributor

Marks batch_size and batch_bytes as non-required fields. There are default values for these two fields even if the value is remain unset. So, it doesn't make sense to have these two are required fields.

Testing

  • Added unit tests for new functionality
  • Tested end-to-end using the local server
  • [Segmenters] Tested in the staging environment

Copy link

codecov bot commented Sep 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.18%. Comparing base (571be20) to head (93fb6a6).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2405      +/-   ##
==========================================
- Coverage   83.38%   83.18%   -0.21%     
==========================================
  Files         964      932      -32     
  Lines       18000    16238    -1762     
  Branches     3554     3052     -502     
==========================================
- Hits        15010    13507    -1503     
+ Misses       2807     2540     -267     
- Partials      183      191       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants