CRAB-45722: Add advance project configuration to addon.json #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addon.json
Outdated
| "required": ["display"] | ||
| } | ||
| "advanced_project_configuration": { | ||
| "kernel_name": "python38" |
There was a problem hiding this comment.
Isn't this supposed to define the schema? meaning the kernel name should be a string with a default value another property?
And also, why are we defaulting to python 3.8? Isn't it desirable to switch to 3.11 as soon as possible?
There was a problem hiding this comment.
Made the change, however, still defaulting to 38 since the notebooks are still on 38 and also since the 311 pr which takes care of both situation is yet to merge.
AlexDorobantiu
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the python311 pr is yet to be merged, this PR adds the advance project configuration which includes the python version (3.8) seeq correlation should be installed in for now.