Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Promise reject in tests #1691

Merged
merged 1 commit into from
Sep 29, 2024
Merged

Conversation

samchungy
Copy link
Contributor

@samchungy samchungy commented Sep 29, 2024

I saw a few:

.mockImplementation(() => { return Promise.reject('bad')});

and similar implementation across a few repos. Don't think it's worth forcing them to change it to a throw

@samchungy samchungy requested a review from a team as a code owner September 29, 2024 01:34
Copy link

changeset-bot bot commented Sep 29, 2024

⚠️ No Changeset found

Latest commit: 40aab7e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@samchungy samchungy merged commit 3ee31b9 into main Sep 29, 2024
15 checks passed
@samchungy samchungy deleted the Allow-promise-rejections-in-tests branch September 29, 2024 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants