Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch docker image source to Public ECR #1684

Merged
merged 23 commits into from
Sep 28, 2024
Merged

Switch docker image source to Public ECR #1684

merged 23 commits into from
Sep 28, 2024

Conversation

samchungy
Copy link
Contributor

@samchungy samchungy commented Sep 26, 2024

To prevent us hitting rate limits when pulling images from Docker Hub we need to pull our base images from public ECR instead. This PR updates the templates and creates an autofix for the references in our Dockerfiles and Docker Compose files to pull from ECR.

Resolves #1332

Copy link

changeset-bot bot commented Sep 26, 2024

🦋 Changeset detected

Latest commit: ef5e0ef

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@samchungy samchungy marked this pull request as ready for review September 26, 2024 00:51
@samchungy samchungy requested a review from a team as a code owner September 26, 2024 00:51
Copy link
Contributor

@AaronMoat AaronMoat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good tyvm!

@samchungy samchungy enabled auto-merge (squash) September 28, 2024 01:33
@samchungy samchungy merged commit d8ced2a into main Sep 28, 2024
15 checks passed
@samchungy samchungy deleted the public-ecr branch September 28, 2024 01:35
@seek-oss-ci seek-oss-ci mentioned this pull request Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reference Public ECR Base Images in Docker Images
4 participants