Add version variable to cdk template logger #1548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: d86dd71 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
72636c
reviewed
Apr 23, 2024
…EK/skuba into use-version-cdk-template
72636c
approved these changes
May 8, 2024
| name: config.name, | ||
|
|
||
| transport: | ||
| config.environment === 'local' ? { target: 'pino-pretty' } : undefined, |
There was a problem hiding this comment.
Do we need to declare pino-pretty as a dev dep?
Co-authored-by: Ryan Ling <[email protected]>
samchungy
reviewed
May 9, 2024
(Forgot to run integrations locally)
samchungy
reviewed
May 9, 2024
Includes snapshot update
samchungy
reviewed
May 9, 2024
samchungy
approved these changes
May 9, 2024
|
Thanks for the hard work 🙇 |
AaronMoat
approved these changes
May 18, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue #1401
Extend CDK template to use VERSION variable in logger.
I also re-organised cdk config slightly so that it better matches serverless config at a glance.
I have opted for a patch changeset as per contribution guidelines of minor changes involving templates.