Propose a release preamble #1415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: b24c95a The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Merged
72636c
approved these changes
Feb 5, 2024
There was a problem hiding this comment.
if it will propagate the notes to the
releasessection as well (or perhaps entirely break that?)
I think CHANGELOG.md should be authoritative: https://github.com/seek-oss/skuba/pull/1329/files#diff-06572a96a58dc510037d5efa622f9bec8519bc1beab13c9f251e97e657a9d4ed
But happy to be proven wrong in this release, and we can always ninja edit the release note 🙂
Co-authored-by: Ryan Ling <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 I am not 100% sure if this will break anything, e.g. if it will propagate the notes to the
releasessection as well (or perhaps entirely break that?)Edit: reading the source code for the changesets action, I reckon (but can't promise) it'll be ok
But the release notes for this release are huge and I think adding some important callouts at the top would be nice.