Add skuba migrate command to upgrade projects to Node.js 20
#1382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 8000c5b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
AaronMoat
commented
Jan 12, 2024
AaronMoat
commented
Jan 12, 2024
| @@ -16,6 +16,8 @@ Patch skipped: Upgrade Node.js Distroless Docker image to -debian12 variant - no | |||
|
|
|||
| Patch skipped: Add keepAliveTimeout to server listener - no listener file found | |||
|
|
|||
| Patch skipped: Upgrade Node.js to 20 - unable to find any Node.js <20 usage | |||
There was a problem hiding this comment.
Wonder if we should mock the patches, this might get annoying
AaronMoat
commented
Jan 12, 2024
|
Hmmm I dunno about this one as node 20 upgrades also require bumps to serverless and CDK package versions 🤔. Additionally with the lambda bump there are some breaking changes surrounding certs 🤔 |
|
Could make it a major? It is opt-outable |
AaronMoat
commented
Jan 14, 2024
|
Unsure if we want this in the current release or get that out as a minor: #1329 |
AaronMoat
commented
Jan 16, 2024
AaronMoat
commented
Jan 16, 2024
AaronMoat
changed the title
skuba migrate command to upgrade projects to Node.js 20
samchungy
reviewed
Feb 11, 2024
samchungy
reviewed
Feb 11, 2024
samchungy
approved these changes
Feb 11, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.