Patch to debian12 #1381
Merged
Patch to debian12 #1381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: cd43b7e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
72636c
reviewed
Jan 12, 2024
Comment on lines
11
to
12
| const NON_DEBIAN_REGEX = /gcr.io\/distroless\/nodejs:(16|18|20)/g; | ||
| const DEBIAN_REGEX = /gcr.io\/distroless\/nodejs(16|18|20)-debian11/g; |
There was a problem hiding this comment.
It looks like there is no nodejs16-debian12 support: https://console.cloud.google.com/gcr/images/distroless
There was a problem hiding this comment.
Ooh that's complicated then. Maybe it should be two patches
There was a problem hiding this comment.
Ah, but skuba 7.0.0 required node 18 so this won't run on 16 anyway - maybe we just do the 18/20?
72636c
approved these changes
Jan 12, 2024
Merged
ajain58
pushed a commit
to ajain58/skuba
that referenced
this pull request
Jan 17, 2024
* Patch to debian12 * Run `skuba format` * No node16 support * Update five-kiwis-laugh.md * Update Dockerfile --------- Co-authored-by: skuba <[email protected]> Co-authored-by: Ryan Ling <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1380