Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uplift internal linting #1370

Merged
merged 17 commits into from
Jan 10, 2024
Merged

Uplift internal linting #1370

merged 17 commits into from
Jan 10, 2024

Conversation

AaronMoat
Copy link
Contributor

@AaronMoat AaronMoat commented Jan 6, 2024

Replacing #1346, but same motivation:

Currently, if .gitignore/other ignore files need to be fixed by format, you can get away with never having them fixed because lint never fails. I've seen cases where they're not pushed with autofix (unsure if always or just if no write perms?)
...
Fairly important to get right before pnpm / managing npmrc

Goal is:

  • Lint is readonly, but autofixes still work in CI
  • format and lint do the same things (but readonly vs write)
  • Nice output

I'm still newish to this codebase, so there may be crimes here, and my manual and automated testing is somewhat limited, so things to look out for tests to add (or run) would be appreciated.

@AaronMoat AaronMoat requested review from a team as code owners January 6, 2024 03:52
Copy link

changeset-bot bot commented Jan 6, 2024

🦋 Changeset detected

Latest commit: 6a10c00

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
skuba Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@72636c 72636c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Description makes sense 👍. Just opining on the TODOs, I'll take a more detailed look later.

src/cli/lint/upgrade/index.ts Outdated Show resolved Hide resolved
src/cli/lint/upgrade/index.ts Outdated Show resolved Hide resolved
src/cli/lint/upgrade/index.ts Outdated Show resolved Hide resolved
src/cli/lint/upgrade/index.ts Outdated Show resolved Hide resolved
Copy link
Member

@72636c 72636c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bigly effort, ty 🙌

Comment on lines +11 to +12
description:
'Add empty exports to Jest files for compliance with TypeScript isolated modules',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thoughts on us having documentation (e.g. another page similar to https://seek-oss.github.io/skuba/CHANGELOG.html) that provides more context on each patch that we can link from the CLI?

Not for this PR, but I'm happy to take a look at this if we agree it's a decent idea. Not sure if it would be overkill for the average patch, though we tend to write detailed explanations already that end up buried in the changelog via Changesets.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah that could be good. Maybe if we give them IDs/names we could also later give a way to opt out of a change (e.g. node 20 later)

src/cli/configure/patchRenovateConfig.ts Outdated Show resolved Hide resolved
src/cli/configure/patchRenovateConfig.ts Outdated Show resolved Hide resolved
src/cli/configure/patchRenovateConfig.ts Outdated Show resolved Hide resolved
src/cli/configure/patchRenovateConfig.ts Outdated Show resolved Hide resolved
src/cli/lint/internalLints/refreshIgnoreFiles.ts Outdated Show resolved Hide resolved
src/cli/format.ts Outdated Show resolved Hide resolved
src/cli/configure/upgrade/patches/7.3.1/index.ts Outdated Show resolved Hide resolved
src/cli/configure/upgrade/patches/7.3.1/index.ts Outdated Show resolved Hide resolved
.changeset/five-dancers-pump.md Outdated Show resolved Hide resolved
Copy link
Member

@72636c 72636c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@AaronMoat
Copy link
Contributor Author

Thanks, you're very good at copyediting :)

@AaronMoat AaronMoat merged commit 2e6abb3 into master Jan 10, 2024
18 checks passed
@AaronMoat AaronMoat deleted the internal-lint branch January 10, 2024 01:35
@seek-oss-ci seek-oss-ci mentioned this pull request Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants