-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add blue-green deployments to sqs cdk template #1327
Conversation
🦋 Changeset detectedLatest commit: 9bae933 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I may have done something wrong but I had to add the following to deploy under pnpm:
public-hoist-pattern[]=esbuild
public-hoist-pattern[]=ts-node
Alternatively we could specify these as direct dependencies
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can get around this one by using skuba node in the command to run CDK?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"app": "npx ts-node infra/index.ts", |
esbuild needing to be hoisted or an explicit dep sounds right to me.
CDK calls the cli directly from what I remember
Resolves #1311