-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update distroless nodejs image #1224
Conversation
🦋 Changeset detectedLatest commit: bbff592 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we autopatch this or just tell consumers to? 🤷
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We probably need to agree on a more systematic approach for introducing and later retiring custom patches like this, but makes a lot of sense here 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re this, I'm thinking maybe with every major version we retire custom patches. Somewhere in the readme we should add a section on upgrading and suggest that consumers go up major version's one at a time perhaps?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We probably need to agree on a more systematic approach for introducing and later retiring custom patches like this, but makes a lot of sense here 👍
The current image has these vulnerabilities flagged in ECR but the new
-debian11
image is free from them.For whatever reason, this image isn't using the latest deps/libs? I haven't quite looked at why but the documentation now recommends
gcr.io/distroless/nodejs18-debian11
by defaulthttps://github.com/GoogleContainerTools/distroless/blob/main/nodejs/README.md