Remove 'warm' build steps from the template pipelines #1223
Conversation
|
| - label: 🧖♀️ Warm Prod | ||
| command: ':' | ||
| key: warm-prod | ||
| plugins: | ||
| - *aws-sm | ||
| - *private-npm | ||
| - *docker-ecr-cache |
There was a problem hiding this comment.
The intent here was to bake the Docker build image and upload it to ECR once, rather than doing it twice on Test & Lint and Build & Package. Thoughts?
There was a problem hiding this comment.
Yeah in my team's repo we call the step build cache
There was a problem hiding this comment.
Yes of course that is still valid.
How about serialising the two steps, so it gets done only once - putting the shortest step first (which I think will be Build & Package)? Or am I just wrong, and the warm step should remain.
There was a problem hiding this comment.
If both run at the same time there would be a chance we would get a cache miss right? The build cache step takes a little while
There was a problem hiding this comment.
By "serialise" I meant adding a dependency so that one step always runs after the other, so no chance of a cache miss
There was a problem hiding this comment.
Not to mention it might fail while quicker while running both lint and build at the same time = faster feedback
There was a problem hiding this comment.
I am investigating / gathering stats.
There was a problem hiding this comment.
Right, as of the new build vCurrent strategy it looks like each step has to do the pull image step, so the question is whether that pull image step is quicker than running the commands on a single step?
There was a problem hiding this comment.
It would be nice if we could somehow lock the ecr cache plugin to only run once per build at a time, then the first one that runs will build + the others will pull once it's finished pushing the image, no need for a warm step. Though I suppose this wouldn't actually save any time (the agent would just have to idle), right?
There was a problem hiding this comment.
This definitely helps in UI repos, given the UI images are typically alot bigger.
It takes on average 1 min 30 seconds to pull the image on one of our UI repos so moving all the commands to the single step has sped it up a bit
|
Per the discussion, this isn't the right change. Sam made a better change by updating the docker-ecr-cache plugin and using the new |
Remove 'warm' build steps from the template pipelines, because they don't have any effect in the new
vCurrentbuild agent queues.These queues don't run steps on the same EC2 instance so there is warming, pre-launching or other time-saved, only an uneccessary cost to run these.
This change does not change Skuba functionality, nor the build-compile of Skuba iteself.