Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version Packages #1180

Merged
merged 1 commit into from
Jul 18, 2023
Merged

Version Packages #1180

merged 1 commit into from
Jul 18, 2023

Conversation

seek-oss-ci
Copy link
Contributor

@seek-oss-ci seek-oss-ci commented May 25, 2023

This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to master, this PR will be updated.

Releases

[email protected]

Major Changes

  • deps: tsconfig-seek 2 (#1175)

    This change sets the noUncheckedIndexedAccess compiler option to true by default.

    This will flag possible issues with indexed access of arrays and records.

    Before:

    const a: string[] = [];
    const b = a[0];
    //    ^? const b: string

    After:

    const a: string[] = [];
    const b = a[0];
    //    ^? const b: string | undefined

    Unfortunately, this change is a double edged sword as your previous code which may look like this may now be invalid.

    if (list.length === 3) {
      const b = list[1];
      //    ^? const b: string | undefined
    }

    To address this you will need to also explicitly check the index you are accessing.

    if (list.length === 3 && list[1]) {
      const b = list[1];
      //    ^? const b: string
    }

    This may seem like overkill, however, when you consider that Javascript will also allow this it may make sense

    const a: string[] = [];
    a[1000] = 'foo';
    console.log(a.length); // 1001

    You can override this setting in your project's tsconfig.json by setting it to false.

    {
      "compilerOptions": {
        "noUncheckedIndexedAccess": false
      }
    }
  • deps: Require Node.js 18.12+ (#1206)

    Node.js 16 will reach end of life by September 2023. We have aligned our version support with sku 18.

    Consider upgrading the Node.js version for your project across:

    • .nvmrc
    • package.json#/engines/node
    • @types/node package version
    • CI/CD configuration (.buildkite/pipeline.yml, Dockerfile, etc.)

Minor Changes

  • deps: esbuild 0.18 (#1190)

    skuba build will continue to infer target from tsconfig.json at this time. See the esbuild release notes for other details.

  • format, lint: Have Prettier respect .gitignore (#1217)

    This aligns with the behaviour of the Prettier 3.0 CLI.

  • deps: TypeScript 5.1 (#1183)

    This major release includes breaking changes. See the TypeScript 5.1 announcement for more information.

  • deps: Prettier 3.0 (#1202)

    See the release notes for more information.

Patch Changes

  • template: Require Node.js 18.12+ (#1206)

  • template/oss-npm-package: Set publishConfig.provenance to true (#1182)

    See https://github.blog/2023-04-19-introducing-npm-package-provenance/ for more information.

  • template/lambda-sqs-worker: Change some info logs to debug (#1178)

    The "Function succeeded" log message was changed from info to debug to reduce the amount of unnecessary logs in production. The message will still be logged in dev environments but at a debug level.

  • tsconfig: Turn off noUnusedLocals and noUnusedParameters (#1181)

    SEEK's ESLint config has a rule which works for both function and types. We do not need both tools to do the same thing and ESLint has better support for ignoring files if needed.

  • lint: Resolve Git root before attempting to autofix (#1215)

  • configure: Resolve Git root before attempting to patch Renovate config (#1215)

  • template/lambda-sqs-worker: Bump aws-sdk-client-mock to 3.0.0 (#1197)

    AWS SDK v3.363.0 shipped with breaking type changes.

@seek-oss-ci seek-oss-ci requested review from a team as code owners May 25, 2023 04:42
@72636c 72636c marked this pull request as draft May 25, 2023 04:45
@seek-oss-ci seek-oss-ci force-pushed the changeset-release/master branch 2 times, most recently from 3ec4d7c to a40e409 Compare May 30, 2023 02:02
@72636c 72636c added the dino:snooze Snooze in Review Dino label Jun 5, 2023
@seek-oss-ci seek-oss-ci force-pushed the changeset-release/master branch 2 times, most recently from ba2e9fa to c937512 Compare June 6, 2023 22:20
@seek-oss-ci seek-oss-ci force-pushed the changeset-release/master branch 6 times, most recently from d1a90a5 to a3a3a57 Compare June 20, 2023 18:26
@seek-oss-ci seek-oss-ci force-pushed the changeset-release/master branch 2 times, most recently from ecd8206 to 79b60f3 Compare June 22, 2023 23:19
@seek-oss-ci seek-oss-ci force-pushed the changeset-release/master branch 8 times, most recently from e209836 to a1e906e Compare July 10, 2023 00:08
@72636c 72636c mentioned this pull request Jul 12, 2023
1 task
@seek-oss-ci seek-oss-ci force-pushed the changeset-release/master branch 4 times, most recently from 3dfaa15 to 13880ba Compare July 13, 2023 08:00
@seek-oss-ci seek-oss-ci force-pushed the changeset-release/master branch 8 times, most recently from 97fe52e to 20a71ad Compare July 14, 2023 04:12
@72636c 72636c removed the dino:snooze Snooze in Review Dino label Jul 14, 2023
@seek-oss-ci seek-oss-ci force-pushed the changeset-release/master branch 3 times, most recently from 35f0624 to 8f53db2 Compare July 17, 2023 22:48
@72636c 72636c marked this pull request as ready for review July 18, 2023 00:06
@72636c 72636c merged commit 9850d7a into master Jul 18, 2023
19 checks passed
@72636c 72636c deleted the changeset-release/master branch July 18, 2023 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants