RFC: Fix CI (#1398)

* RFC: Fix CI

Prettier has gained support for honouring trailing comma configuration
in JSONC files and is applying this to our `tsconfig.json`s.

I'm not entirely convinced by this change, and could be persuaded to
mess with our Prettier adapter and toggle trailing commas off for
`tsconfig.json` in particular. Notably this is not affecting our
`tsconfig.build.json` which could appear inconsistent.

* More?

* Try something

* Even more

* Delete `tsconfig` configure module

This didn't support JSONC and I don't think it's worthwhile to rebuild.

* Placate our own lint

* Extend changesets

* Bump `@types/node`

.changeset/great-trains-doubt.md

@@ -4,4 +4,20 @@
 
 deps: Prettier 3.2
 
+A notable change in this release is the application of trailing newlines to JSONC files, including `tsconfig.json`:
+
+```diff
+{
+  "compilerOptions": {
+    "lib": ["ES2022"],
+    "outDir": "lib",
+-   "target": "ES2022"
++   "target": "ES2022",
+  },
+  "exclude": ["lib*/**/*"],
+- "extends": "skuba/config/tsconfig.json"
++ "extends": "skuba/config/tsconfig.json",
+}
+```
+
 See the [release notes](https://prettier.io/blog/2024/01/12/3.2.0) for more information.

.changeset/little-goats-chew.md

@@ -0,0 +1,7 @@
+---
+'skuba': patch
+---
+
+build: Apply trailing newlines to `skuba/config/tsconfig.json`
+
+This aligns with Prettier 3.2 formatting behaviour. If your project references this file in a non-standard manner outside of the `tsconfig.json#/extends` field, ensure that you are using a JSONC-compatible parser.

config/tsconfig.json

@@ -5,7 +5,7 @@
     "moduleResolution": "node",
     "resolveJsonModule": true,
     "noUnusedLocals": false,
-    "noUnusedParameters": false
+    "noUnusedParameters": false,
   },
-  "extends": "tsconfig-seek"
+  "extends": "tsconfig-seek",
 }

integration/base/fixable/tsconfig.json

@@ -3,7 +3,7 @@
     "incremental": true,
     "moduleResolution": "node",
     "outDir": "lib",
-    "skipLibCheck": true
+    "skipLibCheck": true,
   },
-  "extends": "tsconfig-seek"
+  "extends": "tsconfig-seek",
 }

integration/base/ok/tsconfig.json

@@ -3,7 +3,7 @@
     "incremental": true,
     "moduleResolution": "node",
     "outDir": "lib",
-    "skipLibCheck": true
+    "skipLibCheck": true,
   },
-  "extends": "tsconfig-seek"
+  "extends": "tsconfig-seek",
 }

integration/base/patch/tsconfig.json

@@ -3,7 +3,7 @@
     "incremental": true,
     "moduleResolution": "node",
     "outDir": "lib",
-    "skipLibCheck": true
+    "skipLibCheck": true,
   },
-  "extends": "tsconfig-seek"
+  "extends": "tsconfig-seek",
 }

integration/base/unfixable/tsconfig.json

@@ -3,7 +3,7 @@
     "incremental": true,
     "moduleResolution": "node",
     "outDir": "lib",
-    "skipLibCheck": true
+    "skipLibCheck": true,
   },
-  "extends": "tsconfig-seek"
+  "extends": "tsconfig-seek",
 }

package.json

@@ -102,8 +102,8 @@
     "npm-run-path": "^4.0.1",
     "npm-which": "^3.0.1",
     "picomatch": "^3.0.0",
-    "prettier": "~3.2.0",
-    "prettier-plugin-packagejson": "^2.4.6",
+    "prettier": "~3.2.4",
+    "prettier-plugin-packagejson": "^2.4.9",
     "read-pkg-up": "^7.0.1",
     "semantic-release": "^21.0.0",
     "serialize-error": "^8.0.1",

src/cli/configure/analysis/__snapshots__/project.test.ts.snap

@@ -145,32 +145,6 @@ export {};
     "version": "0.0.0-semantically-released"
   }
 }
-",
-    "operation": "A",
-  },
-  "tsconfig.build.json": {
-    "data": "{
-  "exclude": ["**/__mocks__/**/*", "**/*.test.ts", "src/testing/**/*"],
-  "extends": "./tsconfig.json",
-  "include": ["src/**/*"]
-}
-",
-    "operation": "A",
-  },
-  "tsconfig.json": {
-    "data": "{
-  "compilerOptions": {
-    "baseUrl": ".",
-    "lib": ["ES2022"],
-    "outDir": "lib",
-    "paths": {
-      "src": ["src"]
-    },
-    "target": "ES2022"
-  },
-  "exclude": ["lib*/**/*"],
-  "extends": "skuba/config/tsconfig.json"
-}
 ",
     "operation": "A",
   },

src/cli/configure/modules/index.ts

@@ -9,7 +9,6 @@ import { prettierModule } from './prettier';
 import { renovateModule } from './renovate';
 import { serverlessModule } from './serverless';
 import { skubaDiveModule } from './skubaDive';
-import { tsconfigModule } from './tsconfig';
 import { tslintModule } from './tslint';
 
 export const loadModules = (opts: Options): Promise<Module[]> =>
@@ -24,7 +23,6 @@ export const loadModules = (opts: Options): Promise<Module[]> =>
       renovateModule,
       serverlessModule,
       skubaDiveModule,
-      tsconfigModule,
       tslintModule,
     ].map((createModule) => createModule(opts)),
   );