Skip to content

Commit

Permalink
RFC: Fix CI
Browse files Browse the repository at this point in the history
Prettier has gained support for honouring trailing comma configuration
in JSONC files and is applying this to our `tsconfig.json`s.

I'm not entirely convinced by this change, and could be persuaded to
mess with our Prettier adapter and toggle trailing commas off for
`tsconfig.json` in particular. Notably this is not affecting our
`tsconfig.build.json` which could appear inconsistent.
  • Loading branch information
72636c committed Jan 19, 2024
1 parent 928741f commit fe09c7c
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 7 deletions.
6 changes: 3 additions & 3 deletions template/base/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,10 @@
"lib": ["ES2022"],
"outDir": "lib",
"paths": {
"src": ["src"]
"src": ["src"],
},
"target": "ES2022"
"target": "ES2022",
},
"exclude": ["lib*/**/*"],
"extends": "skuba/config/tsconfig.json"
"extends": "skuba/config/tsconfig.json",
}
4 changes: 2 additions & 2 deletions template/oss-npm-package/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@
"lib": ["ES2022"],
"outDir": "lib",
"removeComments": false,
"target": "ES2022"
"target": "ES2022",
},
"exclude": ["lib*/**/*"],
"extends": "skuba/config/tsconfig.json"
"extends": "skuba/config/tsconfig.json",
}
4 changes: 2 additions & 2 deletions template/private-npm-package/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@
"lib": ["ES2022"],
"outDir": "lib",
"removeComments": false,
"target": "ES2022"
"target": "ES2022",
},
"exclude": ["lib*/**/*"],
"extends": "skuba/config/tsconfig.json"
"extends": "skuba/config/tsconfig.json",
}

0 comments on commit fe09c7c

Please sign in to comment.