Skip to content

Commit

Permalink
Upgrade to Node 20 as per the semantic release requirements
Browse files Browse the repository at this point in the history
  • Loading branch information
AaronMoat committed Sep 8, 2024
1 parent 6a23e39 commit b7f0659
Show file tree
Hide file tree
Showing 11 changed files with 21 additions and 17 deletions.
6 changes: 5 additions & 1 deletion .changeset/renovate-6eb125a.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
---
'skuba': patch
'skuba': major
---

deps: semantic-release ^24.0.0

This major upgrade bumps our minimum requirement from Node.js 18.18 to 20.8.1.

If using Node.js 18, a previous release landed a [`skuba migrate`](https://seek-oss.github.io/skuba/docs/cli/migrate.html) command to simplify upgrades to Node.js 20. Node.js 18 reaches EOL in April 2025.
2 changes: 1 addition & 1 deletion integration/base/patch/Dockerfile
Original file line number Diff line number Diff line change
@@ -1 +1 @@
FROM gcr.io/distroless/nodejs:18 AS runtime
FROM gcr.io/distroless/nodejs:20 AS runtime
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@
"@octokit/rest": "^21.0.0",
"@octokit/types": "^13.0.0",
"@types/jest": "^29.0.0",
"@types/node": ">=18.12",
"@types/node": ">=20",
"chalk": "^4.1.0",
"concurrently": "^8.0.0",
"dotenv": "^16.0.0",
Expand Down Expand Up @@ -161,7 +161,7 @@
},
"packageManager": "[email protected]",
"engines": {
"node": ">=18.18.0"
"node": ">=20.8.1"
},
"publishConfig": {
"provenance": true
Expand Down
8 changes: 4 additions & 4 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion template/express-rest-api/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,6 @@
},
"packageManager": "[email protected]",
"engines": {
"node": ">=20"
"node": ">=20.8.1"
}
}
2 changes: 1 addition & 1 deletion template/greeter/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,6 @@
},
"packageManager": "[email protected]",
"engines": {
"node": ">=20"
"node": ">=20.8.1"
}
}
2 changes: 1 addition & 1 deletion template/koa-rest-api/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,6 @@
},
"packageManager": "[email protected]",
"engines": {
"node": ">=20"
"node": ">=20.8.1"
}
}
2 changes: 1 addition & 1 deletion template/lambda-sqs-worker-cdk/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,6 @@
},
"packageManager": "[email protected]",
"engines": {
"node": ">=20"
"node": ">=20.8.1"
}
}
2 changes: 1 addition & 1 deletion template/lambda-sqs-worker/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,6 @@
},
"packageManager": "[email protected]",
"engines": {
"node": ">=20"
"node": ">=20.8.1"
}
}
4 changes: 2 additions & 2 deletions template/oss-npm-package/_package.json
Original file line number Diff line number Diff line change
Expand Up @@ -34,13 +34,13 @@
},
"dependencies": {},
"devDependencies": {
"@types/node": "^18.19.8",
"@types/node": "^20.14.8",
"commitizen": "^4.2.4",
"skuba": "*"
},
"packageManager": "[email protected]",
"engines": {
"node": ">=18.12"
"node": ">=20.8.1"
},
"publishConfig": {
"provenance": true
Expand Down
4 changes: 2 additions & 2 deletions template/private-npm-package/_package.json
Original file line number Diff line number Diff line change
Expand Up @@ -34,12 +34,12 @@
},
"dependencies": {},
"devDependencies": {
"@types/node": "^18.19.8",
"@types/node": "^20.14.8",
"commitizen": "^4.2.4",
"skuba": "*"
},
"packageManager": "[email protected]",
"engines": {
"node": ">=18.12"
"node": ">=20.8.1"
}
}

0 comments on commit b7f0659

Please sign in to comment.