First cut of ESLint upgrade

.changeset/changelog.js

@@ -7,13 +7,15 @@ const repo = 'seek-oss/sku';
 
 const changelogFunctions = {
   getDependencyReleaseLine: async (changesets, dependenciesUpdated) => {
-    if (dependenciesUpdated.length === 0) return '';
+    if (dependenciesUpdated.length === 0) {
+      return '';
+    }
 
     const changesetLink = `- Updated dependencies [${(
       await Promise.all(
         changesets.map(async (cs) => {
           if (cs.commit) {
-            let { links } = await getInfo({
+            const { links } = await getInfo({
               repo,
               commit: cs.commit,
             });
@@ -37,7 +39,7 @@ const changelogFunctions = {
       .map((l) => l.trimRight());
 
     if (changeset.commit) {
-      let { links } = await getInfo({
+      const { links } = await getInfo({
         repo,
         commit: changeset.commit,
       });
@@ -47,11 +49,8 @@ const changelogFunctions = {
       const summary = `- ${firstLine} (${versionInfo})`;
 
       return `${summary}\n${futureLines.map((l) => `  ${l}`).join('\n')}`;
-    } else {
-      return `\n\n- ${firstLine}\n${futureLines
-        .map((l) => `  ${l}`)
-        .join('\n')}`;
     }
+    return `\n\n- ${firstLine}\n${futureLines.map((l) => `  ${l}`).join('\n')}`;
   },
 };
 

docs/deploy-docs.js

@@ -6,7 +6,6 @@ const GITHUB_TOKEN = process.env.GITHUB_TOKEN;
 const tokenRegex = GITHUB_TOKEN ? new RegExp(GITHUB_TOKEN, 'g') : null;
 
 const log = function (message) {
-  // eslint-disable-next-line no-console
   console.log(
     tokenRegex ? message.replace(tokenRegex, '[GITHUB_TOKEN]') : message,
   );
@@ -26,7 +25,7 @@ ghpages.publish('.', makeConfig(), function (err) {
   if (err) {
     log('Deployment error');
     log(JSON.stringify(err));
-    // eslint-disable-next-line no-process-exit
+
     process.exit(1);
   } else {
     log('Deployment complete!');

eslint.config.js

@@ -0,0 +1,112 @@
+const seek = require('eslint-config-seek');
+const jsdoc = require('eslint-plugin-jsdoc');
+const unicorn = require('eslint-plugin-unicorn');
+const globals = require('globals');
+
+module.exports = [
+  {
+    ignores: [
+      '**/*.less.d.ts',
+      '**/node_modules',
+      '**/coverage/',
+      '**/dist/',
+      '**/dist-build/',
+      '**/dist-start/',
+      '**/storybook-static/',
+      '**/report/',
+      '**/template/',
+      'test/test-cases/*/*',
+      '!test/test-cases/*/*.test.js',
+      'fixtures/*/*',
+    ],
+  },
+  ...seek,
+  {
+    plugins: {
+      jsdoc,
+      unicorn,
+    },
+
+    languageOptions: {
+      globals: {
+        __SKU_SRC_PATHS_0__: true,
+        __SKU_SRC_PATHS_1__: true,
+        __SKU_SRC_PATHS_2__: true,
+        __SKU_SRC_PATHS_3__: true,
+        __SKU_SRC_PATHS_4__: true,
+        __SKU_SRC_PATHS_5__: true,
+        __SKU_SRC_PATHS_6__: true,
+        __SKU_SRC_PATHS_7__: true,
+        __SKU_SRC_PATHS_8__: true,
+        __SKU_SRC_PATHS_9__: true,
+        __SKU_CLIENT_PATH__: true,
+        __SKU_PUBLIC_PATH__: true,
+        __SKU_CSP__: true,
+        __SKU_DEV_HTTPS__: true,
+        __SKU_DEV_MIDDLEWARE_ENABLED__: true,
+        __SKU_DEV_MIDDLEWARE_PATH__: true,
+        __SKU_LIBRARY_NAME__: true,
+        __SKU_LIBRARY_FILE__: true,
+      },
+    },
+
+    settings: {
+      react: {
+        version: '18.3.1',
+      },
+
+      'import-x/resolver': {
+        node: {
+          moduleDirectory: ['node_modules'],
+        },
+      },
+    },
+
+    rules: {
+      'jsdoc/check-alignment': 2,
+      'jsdoc/check-types': 2,
+
+      'jsdoc/no-multi-asterisks': [
+        'error',
+        {
+          allowWhitespace: true,
+        },
+      ],
+
+      'jsdoc/require-asterisk-prefix': ['error', 'always'],
+      'no-console': 'off',
+      'no-process-exit': 'off',
+      'no-sync': 'off',
+
+      'import-x/no-unresolved': [
+        'error',
+        {
+          commonjs: true,
+          amd: true,
+
+          ignore: [
+            '__sku_alias__renderEntry',
+            '__sku_alias__serverEntry',
+            '__sku_alias__clientEntry',
+            '__sku_alias__webpackStats',
+          ],
+        },
+      ],
+
+      'one-var': ['error', 'never'],
+      'react/jsx-uses-react': 'off',
+      'react/react-in-jsx-scope': 'off',
+      'unicorn/prefer-node-protocol': 'error',
+    },
+  },
+  {
+    files: ['tests/**', 'test-utils/**'],
+
+    languageOptions: {
+      globals: {
+        ...globals.jest,
+        browser: true,
+      },
+    },
+  },
+];

fixtures/assertion-removal/.gitignore

@@ -1,9 +1,9 @@
 # managed by sku
 .eslintcache
-.eslintrc
 .prettierrc
 coverage/
 dist/
+eslint.config.js
 report/
 tsconfig.json
 # end managed by sku

fixtures/assertion-removal/.prettierignore

@@ -1,9 +1,9 @@
 # managed by sku
 .eslintcache
-.eslintrc
 .prettierrc
 coverage/
 dist/
+eslint.config.js
 pnpm-lock.yaml
 report/
 tsconfig.json

fixtures/braid-design-system/.gitignore

@@ -1,9 +1,9 @@
 # managed by sku
 .eslintcache
-.eslintrc
 .prettierrc
 coverage/
 dist/
+eslint.config.js
 report/
 tsconfig.json
 # end managed by sku

fixtures/braid-design-system/.prettierignore

@@ -1,9 +1,9 @@
 # managed by sku
 .eslintcache
-.eslintrc
 .prettierrc
 coverage/
 dist/
+eslint.config.js
 pnpm-lock.yaml
 report/
 tsconfig.json

fixtures/custom-src-paths/.gitignore

@@ -1,9 +1,9 @@
 # managed by sku
 .eslintcache
-.eslintrc
 .prettierrc
 coverage/
 dist/
+eslint.config.js
 report/
 tsconfig.json
 # end managed by sku

fixtures/custom-src-paths/.prettierignore

@@ -1,9 +1,9 @@
 # managed by sku
 .eslintcache
-.eslintrc
 .prettierrc
 coverage/
 dist/
+eslint.config.js
 pnpm-lock.yaml
 report/
 tsconfig.json

fixtures/library-build/.gitignore

@@ -1,9 +1,9 @@
 # managed by sku
 .eslintcache
-.eslintrc
 .prettierrc
 coverage/
 dist/
+eslint.config.js
 report/
 tsconfig.json
 # end managed by sku

fixtures/library-build/.prettierignore

@@ -1,9 +1,9 @@
 # managed by sku
 .eslintcache
-.eslintrc
 .prettierrc
 coverage/
 dist/
+eslint.config.js
 pnpm-lock.yaml
 report/
 tsconfig.json