build: use pep621 pyproject.toml #372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huynguyent
approved these changes
Jul 17, 2022
|
To pin down all the dependencies? Possibly, although it might make it less useable as a library. What actually inspired me to do this was https://github.com/pdm-project/pdm |
Merged
tekumara
added a commit
that referenced
this pull request
Jul 27, 2022
moving to pyproject.toml in #372 broke the tagger because `python setup.py --version` now returns `0.0.0`
Merged
tekumara
added a commit
that referenced
this pull request
Jul 30, 2022
also fixes the build cache and toast.yml to use pyproject.toml introduced in #372
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PEP 621 provides a standardised way for storing project metadata including dependencies declaratively in pyproject.toml, instead of setup.py which is very dynamic. PEP 621 is now supported by setuptools.
This PR uses project settings in pyproject.toml to configure setuptools to build the sdist and wheel.
The built distribution is the same, except the PKG-INFO now includes classifies, keywords, and the full text of the license.
NB: pyproject.toml dependencies are not yet supported by renovatebot (see #10187) or dependabot (see #3290)