Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Android 15 updates #742

Merged
merged 4 commits into from
Sep 12, 2024
Merged

Android 15 updates #742

merged 4 commits into from
Sep 12, 2024

Conversation

theimpulson
Copy link
Collaborator

No description provided.

@theimpulson
Update AGP, Gradle and dependencies to AOSP versions
a334eb0 
* Also regenerate JARs against Android 15 user build

Signed-off-by: Aayush Gupta <[email protected]>
@theimpulson theimpulson mentioned this pull request Sep 9, 2024
Closed
5 tasks
grote
grote requested changes Sep 9, 2024
View reviewed changes
Copy link
Collaborator

@grote grote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks a lot!

Was contactsbackup/libs/com.android.vcard.jar still in the same place or do we need to update the comment?

gradle/libs.versions.toml Outdated Show resolved Hide resolved
@theimpulson
Copy link
Collaborator Author

theimpulson commented Sep 10, 2024 •
edited
Loading

Awesome, thanks a lot!

Was contactsbackup/libs/com.android.vcard.jar still in the same place or do we need to update the comment?

It was still at the same place but I had to run m com.android.vcard command manually to build it.

@grote
Copy link
Collaborator

grote commented Sep 10, 2024

ARgh: IllegalArgumentException: failed to configure com.stevesoltys.seedvault.restore.install.DeviceInfoTest.test supported languages: Package targetSdkVersion=35 > maxSdkVersion=34

What targetSdk does the AOSP build set? is there a way we set target to 34 for now? Or can we change target only for tests?

@theimpulson
Copy link
Collaborator Author

ARgh: IllegalArgumentException: failed to configure com.stevesoltys.seedvault.restore.install.DeviceInfoTest.test supported languages: Package targetSdkVersion=35 > maxSdkVersion=34

What targetSdk does the AOSP build set? is there a way we set target to 34 for now? Or can we change target only for tests?

Done

grote
grote approved these changes Sep 12, 2024
View reviewed changes
Copy link
Collaborator

@grote grote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, thanks!

@grote grote merged commit fa56a74 into seedvault-app:android15 Sep 12, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grote grote grote approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@theimpulson @grote