SECURESIGN-1015 | Make sure route selector labels and managed annos are recconciled

[JasonPowr]

No description provided.

[osmman]

@bouskaJ Could you please review this PR? You have a deeper understanding of base_action

[bouskaJ]

Do we need to do this by operator? Resource labels are not updated by Ensure function at all so user can freely modify them. This is just first question that popped up in my head. Maybe I am missing something.

[JasonPowr]

Do we need to do this by operator? Resource labels are not updated by Ensure function at all so user can freely modify them. This is just first question that popped up in my head. Maybe I am missing something.

@osmman @bouskaJ, You make a good point, I just tested this to 100% confirm and adding the labels manually works without issue. I guess the only thing we loose here by not doing it is the convince of being able to configure it through the API. I suppose it may also be confusing for the customer, if they see the option to configure routeSelectorLabels for ingress sharding they might assume they can add it through the api and update exsisting ingress and route objects.

@osmman WDYT?

[JasonPowr]

/test tas-operator-e2e

[JasonPowr]

/test tas-operator-e2e

[JasonPowr]

@osmman @bouskaJ When you guys have a minute can you take a look? thanks

[JasonPowr]

@bouskaJ @osmman This is good for a re-review, when you guys have a minute, thanks :)

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JasonPowr, osmman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [JasonPowr,osmman]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment