Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(#4) Replace Newtonsoft.Json with System.Text.Json #6

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

y0ung3r
Copy link

@y0ung3r y0ung3r commented Jun 14, 2024

Should close #4

The PolymorphicTypeResolver class was added to (de)serialize abstract classes and interfaces (but it doesn't support generic types for inheritors).

I suppose I could have broken something or missed something. But I think it will help a lot in solving the problem.

@seclerp
Copy link
Owner

seclerp commented Jun 15, 2024

Hi @y0ung3r, thanks for the contribution! I need some time to test it a bit. Overall it looks good to me

@seclerp
Copy link
Owner

seclerp commented Jul 8, 2024

Hi @y0ung3r, I have introduced 2 more JsonConverters (ObjectTypeConverter and ArrayTypeConverter) to fix the issue #7, could you please migrate them as well?

@seclerp
Copy link
Owner

seclerp commented Jul 8, 2024

Please let me know if you need some sort of test project

@y0ung3r
Copy link
Author

y0ung3r commented Jul 9, 2024

Hi @seclerp

I have introduced 2 more JsonConverters (ObjectTypeConverter and ArrayTypeConverter) to fix the issue #7, could you please migrate them as well?

I'll do it when I have some free time

Please let me know if you need some sort of test project

I'll let you know, thank you!

@y0ung3r
Copy link
Author

y0ung3r commented Jul 10, 2024

Hi @seclerp!

In addition, I added tests to check that ArrayTypeConverter and ObjectTypeConverter work properly

@seclerp
Copy link
Owner

seclerp commented Jul 10, 2024

Thank you for your time! Will take a look at it as soon as possible

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace Newtonsoft.Json with System.Text.Json
2 participants