Skip to content

Commit

Permalink
fix: don't scan mapped devices on linux
Browse files Browse the repository at this point in the history
On Linux, process scans with YARA hang if the process has mapped
devices into its virtual memory (see issue VirusTotal#1929).
Blacklist device ID 0,5 which is used by the kernel for files like
devices that do not originate from any device themselves.
Unfortunately, this behavior seems to be undocumented; the only
documentation for device IDs I could find is
https://www.kernel.org/doc/Documentation/admin-guide/devices.txt.
  • Loading branch information
secDre4mer committed Nov 1, 2023
1 parent adeb203 commit fdc4e6b
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion libyara/proc/linux.c
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,7 @@ YR_API const uint8_t* yr_process_fetch_memory_block_data(YR_MEMORY_BLOCK* block)

// Only try mapping the file if it has a path and belongs to a device
if (strlen(proc_info->map_path) > 0 &&
!(proc_info->map_dmaj == 0 && proc_info->map_dmin == 0))
!(proc_info->map_dmaj == 0 && (proc_info->map_dmin == 0 || proc_info->map_dmin == 5)))
{
struct stat st;
fd = open(proc_info->map_path, O_RDONLY);
Expand Down

0 comments on commit fdc4e6b

Please sign in to comment.