Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create AnnotationUsage for one-to-many attributes and flesh out element-collection #99

Merged
merged 2 commits into from
Dec 4, 2023

Conversation

mbladel
Copy link
Collaborator

@mbladel mbladel commented Nov 21, 2023

Addresses #34 and refines what was already implemented for #31.

Comment on lines +449 to +454
// We always use Hibernate specific org.hibernate.annotations.CascadeType since
// it offers additional options than jakarta.persistence.CascadeType
final List<CascadeType> cascadeTypes = new ArrayList<>();
if ( jaxbCascadeType.getCascadeAll() != null ) {
cascadeTypes.add( CascadeType.ALL );
}
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have used org.hibernate.annotations.CascadeType instead of jakarta.persistence.CascadeType, and I applied them with the annotation org.hibernate.annotations.Cascade instead of setting the attribute cascade on the parent annotation. I did it this way because in the xml we could have values that are not supported by JPA (i.e. REPLICATE and LOCK).

@mbladel
Copy link
Collaborator Author

mbladel commented Nov 21, 2023

CI compilation is failing due to methods not recognized on the JaxbPluralAttribute interface that I recently updated in https://github.com/sebersole/hibernate-orm/tree/jpa32. I did publish a new 7.0.0-SNAPSHOT version, and I have no problems compiling locally after refreshing dependencies. Any idea how to solve this?

Edit: re-run the job after a while and compilation completed successfully.

@sebersole sebersole merged commit b7e7b77 into sebersole:main Dec 4, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants