Skip to content

Commit

Permalink
fix releases (#16)
Browse files Browse the repository at this point in the history
* use non forked semantic-release

* ignore packages/*
  • Loading branch information
zhammer authored Jan 30, 2024
1 parent e93652b commit d8bf7ef
Show file tree
Hide file tree
Showing 5 changed files with 887 additions and 891 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -52,4 +52,4 @@ jobs:
node-version: 20.x
cache: 'yarn'
- run: yarn install
- run: yarn multi-semantic-release --dry-run
- run: yarn multi-semantic-release --ignore-packages packages/app,packages/backend --dry-run
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,4 +29,4 @@ jobs:
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
NPM_TOKEN: ${{ secrets.NPM_TOKEN }}
run: yarn multi-semantic-release
run: yarn multi-semantic-release --ignore-packages packages/app,packages/backend
4 changes: 2 additions & 2 deletions docs/MAINTAINERS.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

### Tooling

We use [multi-semantic-release](https://github.com/qiwi/multi-semantic-release) to automate release of the many (sometimes interdependent) plugins in this repo. It is a wrapper on top of [semantic-release](https://semantic-release.gitbook.io/semantic-release/) that extends `semantic-release` to work for monorepos.
We use [multi-semantic-release](https://github.com/dhoulb/multi-semantic-release) to automate release of the many (sometimes interdependent) plugins in this repo. It is a wrapper on top of [semantic-release](https://semantic-release.gitbook.io/semantic-release/) that extends `semantic-release` to work for monorepos.

### `package.json` versions

Expand All @@ -31,4 +31,4 @@ See [this note](https://github.com/semantic-release/semantic-release/discussions

### Future

_`multi-semantic-release` is, by the maintainers' own admission, a hack on top of [semantic-release](https://github.com/semantic-release/semantic-release), but seems to serve its purpose well now, and is used by [other Backstage plugin providers](https://github.com/janus-idp/backstage-plugins/blob/e6ba8e3c5f38381e5e1e74ebd3dac8f20567cc76/package.json#L54) (though we opt for a more up to date fork.) It does a better job than any current alternate option, and explains its advantage well [here](https://github.com/dhoulb/multi-semantic-release?tab=readme-ov-file#iteration-vs-coordination). The maintainers are migrating to their own [tool](https://github.com/semrel-extra/zx-bulk-release) which is in early dev now but is worth exploring in the future._
_`multi-semantic-release` is, by the maintainers' own admission, a hack on top of [semantic-release](https://github.com/semantic-release/semantic-release), but seems to serve its purpose well now, and is used by [other Backstage plugin providers](https://github.com/janus-idp/backstage-plugins/blob/e6ba8e3c5f38381e5e1e74ebd3dac8f20567cc76/package.json#L54). It does a better job than any current alternate option, and explains its advantage well [here](https://github.com/dhoulb/multi-semantic-release?tab=readme-ov-file#iteration-vs-coordination). The maintainers are migrating to their own [tool](https://github.com/semrel-extra/zx-bulk-release) which is in early dev now but is worth exploring in the future._
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
"@backstage/cli": "^0.25.1",
"@backstage/e2e-test-utils": "^0.1.0",
"@playwright/test": "^1.32.3",
"@qiwi/multi-semantic-release": "^7.1.1",
"multi-semantic-release": "^3.0.2",
"@spotify/prettier-config": "^12.0.0",
"concurrently": "^8.0.0",
"lerna": "^7.3.0",
Expand Down
Loading

0 comments on commit d8bf7ef

Please sign in to comment.