feat: add base_url parsing #2399
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JosephLenton
force-pushed
the
feat-base-url
branch
from
65ee65e
to
ac07cc9
Compare
JosephLenton
commented
Aug 24, 2024
Comment on lines
+1998
to
+2002
| Some(ref base_url) => Url::options() | ||
| .base_url(Some(base_url)) | ||
| .parse(url.as_str()) | ||
| .map_err(crate::error::builder) | ||
| .and_then(IntoUrlSealed::into_url), |
There was a problem hiding this comment.
This is the only part of the code I find suspect, as maybe this should live in IntoUrl. I was not too sure on the best way to make changes there without changing the trait (that I was trying to avoid).
For the base_url behaviour, I have deferred to how it is implemented in the Url crate. This is documented here: https://docs.rs/url/latest/url/struct.Url.html#method.join
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for
base_urlto the client when making a request.Changes
ClientBuilder::base_urlfor setting a base url for the client.Client::sendto use the base url, if it is set.Implements #988