Add TryFrom<HttpRequest<()>> for Request #2196
Open
+87
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gerhut
force-pushed
the
try_from_http_request_without_body
branch
from
de4409a
to
ef89c85
Compare
Gerhut
force-pushed
the
try_from_http_request_without_body
branch
from
ef89c85
to
91d787d
Compare
|
in #2307, I did another implementation, which is much simpler, but stores body differently ( I did my own investigation into this issue before I found this PR, so I'd be happy if either one is merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http::Request<()>is a common pattern of requests without body in the http library, but it cannot be converted intoreqwest::Request. This PR adds such case.