Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Always use POST to normalize request serialization #69

Merged
merged 1 commit into from
Oct 30, 2023
Merged

Conversation

razor-x
Copy link
Contributor

@razor-x razor-x commented Oct 30, 2023

This intention is for GET to be used when possible, but blocking issues mean we need to use POST until we can ensure consistent request serialization and parsing for the query string.

@seveibar
Copy link
Contributor

seveibar commented Oct 30, 2023

whats the motivation here? (I agree w/ it fwiw- GET is an optimization we don't need atm)

@sybohy
Copy link

sybohy commented Oct 30, 2023

@seveibar motivation: https://hello-seam.slack.com/archives/C01D0J9ACLF/p1698670175221979

@razor-x razor-x changed the title Always use post feat: Always use POST to normalize request serialization Oct 30, 2023
@razor-x razor-x merged commit 86728d0 into main Oct 30, 2023
7 checks passed
@razor-x razor-x deleted the only-post branch October 30, 2023 22:19
@razor-x
Copy link
Contributor Author

razor-x commented Oct 31, 2023

For all those who cannot see internal Slack threads, here are the details on this change.

  1. All SDKs are moving to generated form. Until this nexlove issue is resolved, all the generated SDK will only use POST (since they don't have access to GET in the openapi spec): OpenAPI spec missing get when post is defined nextlove#117
  2. Seam fully intends to prefer GET in the SDK and docs when GET is properly supported.
  3. (2) is not ready yet due to some blocking issues:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants