-
Notifications
You must be signed in to change notification settings - Fork 544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check CI of full-template branch #78
Merged
Merged
Commits on Aug 8, 2023
-
damithc authored and damithc committed
Aug 8, 2023 Configuration menu - View commit details
-
Copy full SHA for fc76227 - Browse repository at this point
Copy the full SHA fc76227View commit details -
Provide a minimal project template
Let's add the following features to make this a minimal project template that students can use to start their project. * Gradle support, a basic build script * a skeleton JUnit test * a basic CheckStyle configuration * a basic I/O test setup * support for GitHub actions * documentation skeletons inside the docs folder In addition, let's remove the Gradle and JavaFX tutorials as they are not integral to a project template.
damithc authored and damithc committedAug 8, 2023 Configuration menu - View commit details
-
Copy full SHA for ac7e1a7 - Browse repository at this point
Copy the full SHA ac7e1a7View commit details -
Upgrade Checkstyle to 10.2 and reconfigure checks
The latest version of Checkstyle is 10.2. At the same time, the checkstyle.xml file is slightly disorganised. Let's update the Checkstyle version in build.gradle, replace the checkstyle.xml file with the one used in AddressBook 3 and add a suppressions.xml file to support suppression of checks for test code for developers intending to use JUnit.
Configuration menu - View commit details
-
Copy full SHA for 81195f4 - Browse repository at this point
Copy the full SHA 81195f4View commit details -
Update coding standard link and description
The oss-generic link for the coding standard is obsolete. At the same time, the description vaguely refers to a module. Let's change the coding standard link to the one used by SE-EDU and remove the reference to the module.
Configuration menu - View commit details
-
Copy full SHA for 9ebeb41 - Browse repository at this point
Copy the full SHA 9ebeb41View commit details -
The latest minor release for Gradle 6 is 6.9.2. The latest version of the shadow plugin that is compatible with Gradle 6.9.2 is 6.1.0. Let's upgrade to Gradle 6.9.2 and shadow 6.1.0.
Configuration menu - View commit details
-
Copy full SHA for 3d9b3de - Browse repository at this point
Copy the full SHA 3d9b3deView commit details -
The latest version of Gradle is 7.4.2. The mainClassName property has been deprecated and replaced with the mainClass property. The latest shadow version compatible with Gradle 7.4.2 is 7.1.2. Let's upgrade to Gradle 7.4.2, resolve the deprecation and upgrade to shadow 7.1.2.
Configuration menu - View commit details
-
Copy full SHA for f36f86b - Browse repository at this point
Copy the full SHA f36f86bView commit details -
Configuration menu - View commit details
-
Copy full SHA for c380559 - Browse repository at this point
Copy the full SHA c380559View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.