hadolint

Dockerfile

@@ -2,6 +2,7 @@ FROM jlesage/baseimage-gui:debian-11-v4.5.3
 
 SHELL ["/bin/bash", "-o", "pipefail", "-c"]
 
+# hadolint ignore=DL3008
 RUN set -x && \
     TEMP_PACKAGES=() && \
     KEPT_PACKAGES=() && \
@@ -53,8 +54,8 @@ RUN set -x && \
     # Install packages.
     apt-get update && \
     apt-get install -y --no-install-recommends \
-        ${KEPT_PACKAGES[@]} \
-        ${TEMP_PACKAGES[@]} \
+        "${KEPT_PACKAGES[@]}" \
+        "${TEMP_PACKAGES[@]}" \
         && \
 
     # mark libjanson4 as apt autoremoves it on clean and breaks libacars

rootfs/etc/cont-init.d/50-create-jaero-config

@@ -1,17 +1,18 @@
 #!/bin/bash
 
-set -xe
+set -e
+set -u
 
 # Create Jaero Config directory
 if ! [[ -d /config/xdg/config/Jontisoft ]]; then
     mkdir -p /config/xdg/config/Jontisoft/
 fi
 
-if [ ${NUMBER_OF_SDRX_TOPICS} -gt 20 ]; then
+if [ "${NUMBER_OF_SDRX_TOPICS}" -gt 20 ]; then
     echo "Please enter a SDRX topic number less than 21"
     exit 1
 else
-    for i in $(seq -f "%02g" 1 ${NUMBER_OF_SDRX_TOPICS}); do
+    for i in $(seq -f "%02g" 1 "${NUMBER_OF_SDRX_TOPICS}"); do
 cat << END > /config/xdg/config/Jontisoft/"JAERO [${SDRX_TOPIC_NAME}$i].conf"
 [General]
 MQTT_enable=false
@@ -53,4 +54,4 @@ size=1
 END
 
 done
-fi
+fi

rootfs/etc/cont-init.d/51-create-jaero-startapp

@@ -1,6 +1,7 @@
 #!/bin/bash
 
-set -xe
+set -e
+set -u
 
 STARTAPP=/startapp.sh
 
@@ -9,7 +10,7 @@ HOME=/config
 export HOME
 EOF
 
-for i in $(seq -f "%02g" 1 ${NUMBER_OF_SDRX_TOPICS}); do
+for i in $(seq -f "%02g" 1 "${NUMBER_OF_SDRX_TOPICS}"); do
     jaerostart=("/opt/jaero/JAERO -s ${SDRX_TOPIC_NAME}$i")
 cat << EOF >> ${STARTAPP}
 ${jaerostart[@]} > /dev/null 2>&1 &