Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vee dev #3

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Vee dev #3

wants to merge 7 commits into from

Conversation

lavanv1107
Copy link
Collaborator

HTML

  • Add general classes to different divs (utilized more flex)
  • Reorganize different sections
  • Add a footer to the page

CSS

  • Add more general classes for use
  • Reorganize different sections
  • Trim down different sections
  • Add style for main header
  • Add style for footer

JS

  • Add scroll-to-top function for footer

Other

  • Add new bold Robot font for large headers

sdj-sps
sdj-sps reviewed Jul 22, 2021
View reviewed changes
project/src/main/webapp/style.css Outdated
}
/*** Customization ***/
/** Sizing **/
body {margin: 0;}
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did Cloud Shell's auto formatting collapse all these into one line? It's generally considered better style to leave them how you had them before, even though it's less compact.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdj-sps sdj-sps sdj-sps left review comments

@FerrinThreatt FerrinThreatt Awaiting requested review from FerrinThreatt

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lavanv1107 @sdj-sps