Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typos: fix minor typos in code #876

Merged
merged 1 commit into from
Dec 11, 2023
Merged

Typos: fix minor typos in code #876

merged 1 commit into from
Dec 11, 2023

Conversation

mykaul
Copy link
Contributor

@mykaul mykaul commented Dec 9, 2023

Mainly in comments.

Fixes: #875

Pre-review checklist

  • I have split my patch into logically separate commits.
  • All commit messages clearly explain what they change and why.
  • I added relevant tests for new features and bug fixes.
  • All commits compile, pass static checks and pass test.
  • PR description sums up the changes and reasons why they should be introduced.
  • I have provided docstrings for the public items that I want to introduce.
  • I have adjusted the documentation in ./docs/source/.
  • I added appropriate Fixes: annotations to PR description.

@mykaul
Typos: fix minor typos in code
64452dd 
Mainly in comments.

Fixes: scylladb#875
Signed-off-by: Yaniv Kaul <[email protected]>
@piodul
Copy link
Collaborator

piodul commented Dec 11, 2023

https://github.com/scylladb/scylla-rust-driver/actions/runs/7151594195/job/19476066249?pr=876

Known issue (#813), I'm retriggering the job.

piodul
piodul approved these changes Dec 11, 2023
View reviewed changes
Copy link
Collaborator

@piodul piodul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks. May I ask which tool are you using to spellcheck? Maybe we can add a CI check later.

@piodul piodul merged commit 7d06b89 into scylladb:main Dec 11, 2023
9 checks passed
@mykaul
Copy link
Contributor Author

mykaul commented Dec 11, 2023

LGTM, thanks. May I ask which tool are you using to spellcheck? Maybe we can add a CI check later.

Codespell. Please wait till scylladb/scylladb#16285 is merged and you can take it from there, I reckon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piodul piodul piodul approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Typos in code (mainly in comments)
2 participants
@mykaul @piodul