Make SerializationError a newtype #865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Error needs to be dynamic, so that users can use their own types, but at the same time allow it to be stored in concrete type (like `QueryError`). `dyn Error` supports downcasting, so it can be used instead of `Any`.
Implementations such as `impl From<SerializationError> for QueryError` don't seem like a good idea when SerializationError is just an alias for `Arc<dyn Error + Send + Sync>`. Make SerializationError a newtype to avoid such general implementations.
12 tasks
piodul
approved these changes
Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-review checklist
This PR consists of first 2 commits of #858
It was split out in order to merge it before #858, so that #862 and #851 can be rebased on top of it.
There are 2 changes made here:
dyn Anytodyn Errorin SerializationError - it also supports downcasting, but is more useful interfaceimpl From<SerializationError> for QueryError, which after desugaring isimpl From<Arc<dyn Error + Send + Sync>> for QueryError- and writing such implementations doesn't seem like a good idea../docs/source/.Fixes:annotations to PR description.