default_policy: Builder: forbid preferring rack without specifing datacenter #775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wprzytula
force-pushed
the
default-policy-harden-api
branch
2 times, most recently
from
49b5289
to
63378a5
Compare
piodul
reviewed
Jul 31, 2023
This is an API restriction continuing of what has already been done in bb09756: as the case of providing preferred rack without specifying the preferred datacenter is invalid, in spirit of the principle “Make illegal states unrepresentable”, `DefaultBuilder`'s API is changed accordingly to disallow creating such configuration. A stray backslash is deleted from a docstring. Docs are updated to reflect the API change.
wprzytula
force-pushed
the
default-policy-harden-api
branch
from
63378a5
to
2118631
Compare
|
v2: made docs less implementation-oriented, more conceptual. |
piodul
approved these changes
Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an API restriction continuing of what has already been done in bb09756: as the case of providing preferred rack without specifying the preferred datacenter is invalid, in spirit of the principle “Make illegal states unrepresentable”,
DefaultBuilder's API is changed accordingly to disallow creating such configuration.Pre-review checklist
[ ] I added relevant tests for new features and bug fixes.[ ] I have adjusted the documentation in./docs/source/.[ ] I added appropriateFixes:annotations to PR description.