Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

frame: reduce visibility of several funcs/consts #764

Merged
merged 1 commit into from
Jul 20, 2023

Conversation

avelanarius
Copy link

Reduce visibility of several functions and constants which are only used internally within frame and don't have to be exposed publicly. In this patch only the most obvious ones are tackled (ones that require a change solely in scylla-cql). This change is a part of our effort to stabilize the API.

Refs #660

Pre-review checklist

  • I have split my patch into logically separate commits.
  • All commit messages clearly explain what they change and why.
  • I added relevant tests for new features and bug fixes.
  • All commits compile, pass static checks and pass test.
  • PR description sums up the changes and reasons why they should be introduced.
  • I have provided docstrings for the public items that I want to introduce.
  • I have adjusted the documentation in ./docs/source/.
  • I added appropriate Fixes: annotations to PR description.

Reduce visibility of several functions and constants which are only
used internally within frame and don't have to be exposed publicly.
In this patch only the most obvious ones are tackled (ones that require
a change solely in scylla-cql). This change is a part of our effort
to stabilize the API.

Refs scylladb#660
@avelanarius avelanarius added this to the 1.0.0 milestone Jul 19, 2023
@piodul piodul merged commit 69493a1 into scylladb:main Jul 20, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants