routing: remove Node struct #762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove struct scylla::routing::Node from routing.rs. This structure was introduced in 2020 in 1c8df89 and it is unused in our current code (and it looks like the original commit didn't even use it at all). Moreover, this struct clashes with scylla::transport::Node making it error-prone to find the wrong Node struct for a user of the driver. The deleted Node structure also relied solely on SocketAddr, while we want to identify the nodes by host_id (as in scylla::transport::Node). Refs scylladb#660.
piodul
approved these changes
Jul 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove struct
scylla::routing::Nodefromrouting.rs. This structure was introduced in 2020 in 1c8df89 and it is unused in our current code (and it looks like the original commit didn't even use it at all).Moreover, this struct clashes with
scylla::transport::Nodemaking it error-prone to find the wrongNodestruct for a user of the driver. The deletedNodestructure also relied solely onSocketAddr, while we want to identify the nodes byhost_id(as inscylla::transport::Node).Refs #660
Pre-review checklist
./docs/source/.Fixes:annotations to PR description.