Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

semver_checks: Revert previous workaround #1051

Merged
merged 1 commit into from
Aug 1, 2024
Merged

semver_checks: Revert previous workaround #1051

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 2 additions & 26 deletions .github/workflows/semver_checks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,20 +61,7 @@ jobs:
- name: Install semver-checks
# Official action uses binary releases fetched from GitHub
# If this pipeline becomes too slow, we should do this too.
#
# This works around the Semver violation in tame-index 0.12.2 that renders
# cargo-semver-checks incompilable. Once it gets fixed, revert back
# to using the newest release without customisations.
run: |
pushd ..
git clone https://github.com/obi1kenobi/cargo-semver-checks.git
cd cargo-semver-checks
git checkout v0.32.0
sed -i '0,/tame-index = { version = "0.12"/s//tame-index = { version = "=0.12.1"/' Cargo.toml
cargo build -r
cargo install --no-default-features --path .
popd

run: cargo install cargo-semver-checks --no-default-features --features gix-reqwest
- name: Verify the API compatibilty with PR base
id: semver-pr-check
run: |
Expand Down Expand Up @@ -160,17 +147,6 @@ jobs:
- name: Update rust toolchain
run: rustup update
- name: Install semver-checks
# This works around the Semver violation in tame-index 0.12.2 that renders
# cargo-semver-checks incompilable. Once it gets fixed, revert back
# to using the newest release without customisations.
run: |
pushd ..
git clone https://github.com/obi1kenobi/cargo-semver-checks.git
cd cargo-semver-checks
git checkout v0.32.0
sed -i '0,/tame-index = { version = "0.12"/s//tame-index = { version = "=0.12.1"/' Cargo.toml
cargo build -r
cargo install --no-default-features --path .
popd
run: cargo install cargo-semver-checks --no-default-features --features gix-reqwest
- name: Run semver-checks to see if it agrees with version updates
run: make semver-version
Loading