ci: fix semver checks by pinning working dep version #1050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wprzytula
force-pushed
the
fix-semver-checks-on-working-release
branch
from
ba00ec7
to
3b2a10c
Compare
wprzytula
force-pushed
the
fix-semver-checks-on-working-release
branch
from
3ef34da
to
113f753
Compare
It appears that the update of tame-index from 0.12.1 to 0.12.2 contains API-breaking changes, which result in cargo-semver-checks compilation error. To work around this, a custom setup of cargo-semver-checks is done that pins tame-index to 0.12.1 version. This should be reverted once tame-index issues 0.12.3 that reverts back the breaking changes.
wprzytula
force-pushed
the
fix-semver-checks-on-working-release
branch
from
113f753
to
36ba1b5
Compare
|
SemVer checks CI job has passed on wprzytula#2. This proves that this PR indeed fixes the SemVer checks. |
wprzytula
force-pushed
the
fix-semver-checks-on-working-release
branch
from
36ba1b5
to
53de431
Compare
Lorak-mmk
approved these changes
Jul 31, 2024
wprzytula
pushed a commit
to wprzytula/scylla-rust-driver
that referenced
this pull request
Aug 22, 2024
…working-release ci: fix semver checks by pinning working dep version (cherry picked from commit e0cdccb)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears that the update of tame-index from 0.12.1 to 0.12.2 contains API-breaking changes, which result in cargo-semver-checks compilation error. To work around this, a custom setup of cargo-semver-checks is done that pins tame-index to 0.12.1 version.
This should be reverted once tame-index issues 0.12.3 that reverts back the breaking changes, or once cargo-semver-checks issues a new release that works around the problem.
Pre-review checklist
[ ] I added relevant tests for new features and bug fixes.[ ] I have provided docstrings for the public items that I want to introduce.[ ] I have adjusted the documentation in./docs/source/.[ ] I added appropriateFixes:annotations to PR description.