[cloud images] Add vim-nox and sysstat to images #535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Annamikhlin
reviewed
Aug 22, 2024
packer/scylla_install_image
Outdated
| @@ -79,7 +79,7 @@ if __name__ == '__main__': | |||
| run('apt-get update --allow-insecure-repositories -y', shell=True, check=True) | |||
| run('apt-get full-upgrade -y', shell=True, check=True) | |||
| run('apt-get purge -y apport python3-apport fuse', shell=True, check=True) | |||
| run('apt-get install -y systemd-coredump vim.tiny nload nmap ncat tmux jq python3-boto xfsprogs mdadm initramfs-tools ethtool', shell=True, check=True) | |||
| run('apt-get install -y systemd-coredump vim.tiny nload nmap ncat tmux jq python3-boto xfsprogs mdadm initramfs-tools ethtool vim-nox sysstat ', shell=True, check=True) | |||
There was a problem hiding this comment.
nload - seems should be removed as well
Based on scylladb/siren-devops#1764 (comment) we should add those packages and remove `htop` for the cloud usage Fixes: scylladb/siren-devops#1764
yaronkaikov
force-pushed
the
update-packages-cloud-images
branch
from
d391792
to
4df26c1
Compare
Annamikhlin
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on https://github.com/scylladb/siren-devops/issues/1764#issuecomment-2283469016 we should add those packages and remove
htopfor the cloud usageFixes: https://github.com/scylladb/siren-devops/issues/1764
Testing