[images] build based on ubuntu24.04 #530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaronkaikov
force-pushed
the
move-to-ubuntu-24.04
branch
6 times, most recently
from
b208f89
to
fbedcc5
Compare
yaronkaikov
force-pushed
the
move-to-ubuntu-24.04
branch
3 times, most recently
from
5af4d18
to
5900488
Compare
yaronkaikov
force-pushed
the
move-to-ubuntu-24.04
branch
from
9a642d3
to
3126d9f
Compare
Annamikhlin
approved these changes
Jul 16, 2024
As part of our work in scylladb/scylla-enterprise#4111 Updating our Images to the latest LTS Ubuntu Fixes: scylladb#527
Seen during my debug sessions ``` /opt/scylladb/scylla-machine-image/libexec/scylla_login:13: SyntaxWarning: invalid escape sequence '\|' MSG_HEADER = ''' ```
yaronkaikov
force-pushed
the
move-to-ubuntu-24.04
branch
from
3126d9f
to
98b199f
Compare
Done :-) |
|
@fruch this is ready for merge, please advise about the performance rests you did as part of https://github.com/scylladb/qa-tasks/issues/1729, if the results are better/the same let's merge it /cc @mykaul |
yaronkaikov
added a commit
to yaronkaikov/scylla
that referenced
this pull request
Jul 16, 2024
Now that we added support for Ubuntu24.04 and also migrating our images to be based on that (scylladb/scylla-machine-image#530), we should also modify our docker image Fixes: scylladb#19738
|
Based on https://github.com/scylladb/qa-tasks/issues/1729#issuecomment-2231083515, it seems we are good to go |
avikivity
pushed a commit
to scylladb/scylladb
that referenced
this pull request
Jul 17, 2024
Now that we added support for Ubuntu24.04 and also migrating our images to be based on that (scylladb/scylla-machine-image#530), we should also modify our docker image Fixes: #19738 Closes #19764
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of our work in scylladb/scylla-enterprise#4111
Updating our Images to the latest LTS Ubuntu
Also include a minor syntax fix - 9a642d3
Fixes: #527