-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "pre-allocate swapfile while building image" #493
Conversation
95a88fc
to
7571f62
Compare
@syuu1228 What will happen to our image if we revert this? i assume we will not have swap . right? |
@syuu1228 If we merge this, we will have no swap at all. We should at least create the swap during |
@yaronkaikov No, it will allocate swapfile during scylla_image_setup. |
@syuu1228 Please verify it's working. I am using |
I just checked If the patch applied it should be like this:
But scylla_image_setup on this image seems like not applied the patch:
|
That's wired. @syuu1228 Please use https://jenkins.scylladb.com/job/scylla-master/job/releng-testing/job/ami/288/ to re-build AMI and verify it's working |
Also you should rebase :-) |
This reverts commit 069318b. Related with scylladb#491, we need to reduce snapshot size of the rootfs, we should not pre-allocate swapfile while building image.
7571f62
to
eea580a
Compare
Seems like https://jenkins.scylladb.com/job/scylla-master/job/releng-testing/job/ami/288/ does not build scylla-machine-image package in my branch, probably it's latest master. When I tested on locally built AMI, it just worked: I'm also trying to build AMI on releng-testing/next-machine-image, but keep failing without understandable error message, not sure why. |
Probably because of the last successful next under releng-testing. I fixed it now. next run should work |
Just passed @syuu1228 |
next-machine-image passed: https://jenkins.scylladb.com/job/scylla-master/job/releng-testing/job/next-machine-image/255/
(The difference of swap size is comming from memory size of the instance) |
This reverts commit 069318b.
Related with #491, we need to reduce snapshot size of the rootfs, we should not pre-allocate swapfile while building image.